Move git notes fetching from run-task to the decision task and make them optional#935
Merged
Eijebong merged 1 commit intotaskcluster:mainfrom Apr 16, 2026
Merged
Conversation
jcristau
reviewed
Apr 15, 2026
Eijebong
force-pushed
the
make-notes-optional
branch
from
4d26abc to
b644e55
Compare
jcristau
reviewed
Apr 15, 2026
Eijebong
force-pushed
the
make-notes-optional
branch
2 times, most recently
from
0c9f3b1 to
7031852
Compare
Contributor
Author
|
(I dropped the taskcluster.yml change and pushed empty notes to my fork to get CI green, I'll re-add the |
ahal
reviewed
Apr 15, 2026
Eijebong
force-pushed
the
make-notes-optional
branch
2 times, most recently
from
42d2a60 to
2b20361
Compare
Eijebong
changed the title
Eijebong
commented
Apr 16, 2026
| revision = revision or "HEAD" | ||
| try: | ||
| return self.run("notes", f"--ref={note}", "show", revision).strip() | ||
| self.run("fetch", remote, f"{note}:{note}") |
Contributor
Author
There was a problem hiding this comment.
One downside of doing it here is that we lose the retry path completely
Contributor
There was a problem hiding this comment.
And we call fetch on each get_note instead of just once? (Granted we call get_note just once anyway)
jcristau
approved these changes
Apr 16, 2026
…hem optional This removes the concept of extra refs fetching as it was introduced for this feature alone as it turned out to be quite complex to support if we wanted notes to be optional. The main issue it's fixing is being able to run decision tasks off of repos that don't have that notes branch at all.
Eijebong
added
the
BREAKING CHANGE
Eijebong
force-pushed
the
make-notes-optional
branch
from
2b20361 to
a9cb7ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the concept of extra refs fetching as it was introduced for this feature alone as it turned out to be quite complex to support if we wanted notes to be optional. The main issue it's fixing is being able to run decision tasks off of repos that don't have that notes branch at all.